Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test against examples #3253

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Fix test against examples #3253

merged 1 commit into from
Nov 20, 2020

Conversation

yujunz
Copy link
Member

@yujunz yujunz commented Nov 20, 2020

Tests in examples.remoteBuild.md were skipped unexpectedly

@yujunz
Fix test against examples
32a2f5f 
Tests in examples.remoteBuild.md were skipped unexpectedly
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yujunz
To complete the pull request process, please assign monopole after the PR has been reviewed.
You can assign the PR to them by writing /assign @monopole in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2020
@yujunz yujunz mentioned this pull request Nov 20, 2020
Closed
@yujunz
Copy link
Member Author

yujunz commented Nov 20, 2020

Before fix

mdrip -label remoteBuild examples
echo " "
echo "All done.  No errors."

After fix

mdrip -label remoteBuild examples
#
# Script @remoteBuild from /Users/yujunz/Code/yujunz/kustomize/examples/remoteBuild.md
#
#----------------------------------------------------------------------#  Start 1 of 2
echo "# @remoteBuild (block #1 in remoteBuild) of /Users/yujunz/Code/yujunz/kustomize/examples/remoteBuild.md"

target="https://github.com/kubernetes-sigs/kustomize/examples/multibases?ref=v1.0.6"
test 3 == \
  $(kustomize build $target | grep cluster-a-.*-myapp-pod | wc -l); \
  echo $?
#----------------------------------------------------------------------#  End 1 of 2

#----------------------------------------------------------------------#  Start 2 of 2
echo "# @remoteBuild (block #2 in remoteBuild) of /Users/yujunz/Code/yujunz/kustomize/examples/remoteBuild.md"

target="https://github.com/kustless/kustomize-examples/archive/master.zip//kustomize-examples-master"
test 1 == \
  $(kustomize build $target | grep remote-cm | wc -l); \
  echo $?
#----------------------------------------------------------------------#  End 2 of 2

echo " "
echo "All done.  No errors."

@yujunz yujunz mentioned this pull request Nov 20, 2020
Open
@Shell32-Natsu
Copy link
Contributor

Interesting. Thanks for the fix.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2020
@Shell32-Natsu Shell32-Natsu merged commit e15ede0 into kubernetes-sigs:master Nov 20, 2020
@yujunz yujunz deleted the remote-build branch November 21, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy Awaiting requested review from mengqiy

@phanimarupaka phanimarupaka Awaiting requested review from phanimarupaka

Assignees

@Shell32-Natsu Shell32-Natsu

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yujunz @k8s-ci-robot @Shell32-Natsu